apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Marr <gr...@alum.wpi.edu>
Subject Re: [pre-PATCH] short-circuit logic for apr_sockaddr_info_get()
Date Fri, 20 Sep 2002 18:29:07 GMT
At 02:17 PM 9/20/2002, Jeff Trawick wrote:
>Does anyone have concerns about the API?  There is still some logic 
>cleanup to be done before committing anyway.
>
>+ * @param flags Special processing flags:
>+ * <PRE>
>+ *       APR_IPV4_ADDR_OK          first query for IPv4 addresses; 
>only look
>+ *                                 for IPv6 addresses if the first 
>query failed
>+ *                                 (flag only valid if family is 
>APR_UNSPEC)
>+ *       APR_IPV6_ADDR_OK          first query for IPv6 addresses; 
>only look
>+ *                                 for IPv4 addresses if the first 
>query failed
>+ *                                 (flag only valid if family is 
>APR_UNSPEC)
>+ * </PRE>

It isn't clear from the docs what the effect would be of passing
APR_IPV4_ADDR_OK | APR_IPV6_ADDR_OK for the flags parameter.

According to the code, APR_IPV6_ADDR_OK is ignored if 
APR_IPV4_ADDR_OK is specified.  This should probably be explicit in 
the docs.

-- 
Greg Marr
gregm@alum.wpi.edu


Mime
View raw message