Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 23 Aug 2002 19:15:00 -0700
From: Aaron Bannert <aaron@clove.org>
To: dev@apr.apache.org
Subject: Re: [PATCH] proc_mutex causes core dump
Message-ID: <20020824021500.GY13980@clove.org>
Mail-Followup-To: Aaron Bannert <aaron@clove.org>, dev@apr.apache.org
References: <3D653E61.3010703@pearsoncmg.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3D653E61.3010703@pearsoncmg.com>
User-Agent: Mutt/1.4i

On Thu, Aug 22, 2002 at 03:41:21PM -0400, Chris Darroch wrote:
> Hi --
> 
>    I happened to discover that calling apr_global_mutex_trylock()
> caused a core dump (I'm using Solaris 8, but that doesn't really
> matter here).  It's because line 917 in the apr_proc_mutex_trylock()
> function in apr/locks/unix/proc_mutex.c calls:
> 
> mutex->meth->tryacquire(mutex)
> 
> but the tryacquire function pointer is, for all cases, set to NULL.
> A quick fix, without actually implementing any of the tryacquire
> functions, is below; APR_ENOTIMPL is returned by stub functions instead.

This sounds good to me, I'll commit it and then look at the followup
patch.

-aaron