apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: [PATCH] win32 sendrecv.c cleanup
Date Tue, 06 Aug 2002 15:24:11 GMT
Yes, I sometimes forget that, and certainly we can ifdef it.

One old question ... did 4kb make sense for the sendfile header/trailers
vector?  The new question ... is it large enough to concern you, and 
would it make sense to use another granularity on Netware (1kb, 2kb?)
Letting the sendv logic handle the overflow probably makes sense even
at some 1kb threshold.


----- Original Message ----- 
From: "Brad Nicholes" <BNICHOLES@novell.com>
To: <dev@apr.apache.org>; <wrowe@covalent.net>
Sent: Tuesday, August 06, 2002 7:14 AM
Subject: Re: [PATCH] win32 sendrecv.c cleanup

> Bill,
>      NetWare takes advantage of the Win32 Network_io code since we are
> also on Winsock.  Allocating off of the stack may cause a problem for us
> since NetWare has a fixed size stack.  Can the orginal code be #ifdef'd
> for NETWARE?
> Brad
> Brad Nicholes
> Senior Software Engineer
> Novell, Inc., the leading provider of Net business solutions
> http://www.novell.com 
> >>> "William A. Rowe, Jr." <wrowe@covalent.net> Tuesday, August 06,
> 2002 2:19:32 AM >>>
> Folks,
>   Please review the attached patch that eliminates the rather nasty
> allocations
> that can occur in two situations.  One is in apr_sendv() when we have
> more than
> 50 items, now simply allocate the vectors on the stack [very portable
> across
> win32, from vc5 onwards.]  The other simply allocates a static buffer
> for
> the apr_sendfile headers and trailers vector concatination, and when
> we
> exceed it, we simply sendv out the header or trailer as appropriate.
>   If I hear no objections I'll commit in a day or two.
>   Final question.  We 'devolve' to 64kb per sendfile.  There is a
> comment in there
> about exceeding the timeout.  What on earth does unix do so special
> that it isn't
> a problem over on that side?  A cluestick across my knuckles would be
> appreciated
> before I even think about attacking that code.
> Bill

View raw message