apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: cvs commit: apr/poll/unix pollacc.c
Date Tue, 16 Jul 2002 16:12:55 GMT
On Tue, 16 Jul 2002, William A. Rowe, Jr. wrote:

> At 12:25 AM 7/16/2002, jwoolley@apache.org wrote:
> >jwoolley    2002/07/15 22:25:44
> >
> >   Modified:    poll/unix pollacc.c
> >   Log:
> >   Nuke a warning due to a function that should have been static AFAICT:
> >
> >   pollacc.c:78: warning: no previous prototype for `find_poll_sock'
> >
> >   --- pollacc.c 11 Jul 2002 15:32:18 -0000      1.1
> >   +++ pollacc.c 16 Jul 2002 05:25:44 -0000      1.2
> >   @@ -74,7 +74,7 @@
> >        return APR_SUCCESS;
> >    }
> >
> >   -APR_DECLARE(apr_pollfd_t*) find_poll_sock(apr_pollfd_t *aprset,
> > apr_socket_t *sock)
> >   +static apr_pollfd_t *find_poll_sock(apr_pollfd_t *aprset, apr_socket_t
> > *sock)
>
> Ummm... -1.  You just exported a symbol without namespace protection ;-)

Uhh... What Sander said.  How is my commit exporting a symbol?  It's
*UN*exporting the symbol.  :-)

--Cliff


Mime
View raw message