apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Saccoccio" <r...@fastcgi.com>
Subject RE: [PATCH] apr/threadproc/win32/proc.c:apr_proc_create()
Date Fri, 19 Jul 2002 01:15:17 GMT
> And what was the side-effect of NULL handles to stdout/stderr
> that you observed?  That's what I've been trying to determine.

Oh, sorry.  There was no apparent side effect.  The resulting process had
stdout/stderr HANDLEs of 0 as one would expect.

If they're not set to INVALID_HANDLE_VALUE then you've no way to know that
they're not real.

I could have fooled the existing API into setting them up by creating and
passing bogus apr_file_ts (created with apr_os_file_put()) for stdout and
stderr but that doesn't make much sense.

Your patch is perfect/appropriate.

> Also, which version of Win32?

Win2KSP2

While I've got you on the line, why do you do the dup() (in
apr_procattr_child_in_set()) and close() (in apr_proc_create())?

--rob


Mime
View raw message