apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Saccoccio" <r...@fastcgi.com>
Subject RE: [PATCH] apr/threadproc/win32/proc.c:apr_proc_create()
Date Fri, 19 Jul 2002 00:12:14 GMT
> Um... -1 on committing this sort of code until I we have some explanation
> of what problem the patch attempted to solve.  There is a specific meaning
> to NULL [default to the parent's handles] ... we need to know the behavior
> problem Rob was experiencing.

Yes, but STARTF_USESTDHANDLES was set and those members were NULL.

> There is a better patch to this I'd just committed, that will presume
> it's an all-or-nothing game, you specify all handles and the process
> will have only the handles you define, or specify none and all is well.

Your patch is better/fine.  Thanks.

> Please clarify what mischief the NULL handles caused you, Rob.

I was invoking apr_proc_create() with just a stdin handle.


View raw message