apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sander Striker" <stri...@apache.org>
Subject RE: [PATCH] apr_filepath_merge
Date Sun, 28 Jul 2002 10:10:23 GMT
> From: Sander Striker [mailto:striker@apache.org]
> Sent: 28 July 2002 12:09

> Hi,
> 
> 
> This patch is trying to solve the following problems:
> 
> 1)  apr_filepath_merge("", ".") returns "" instead of "."
> 
> This is a one line fix, but needs to be reviewed in the win32
> case, since a check for "/. /" is missed due to this patch.
> 
> 
> 2)  apr_filepath_merge(".", "") returns "./"

I meant to say 'instead of "."'  in case it wasn't clear.
 
> Is a bit harder.  I wanted the function to exit as early as
> possible, so after the basic checks we just copy basepath and
> exit if addpath == "".
> 
> I wasn't sure how to incorporate this change in the win32
> function, since that is really a nasty piece of code.  If
> someone familiar with that code(wrowe?) could take a look at it,
> I would appreciate it.
> 
> 
> Sander


Mime
View raw message