apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject RE: [PATCH] speed up network timeout processing
Date Wed, 03 Jul 2002 15:28:35 GMT

> > From: trawick@rdu88-250-182.nc.rr.com [mailto:trawick@rdu88-250-
> >
> > "Ryan Bloom" <rbb@covalent.net> writes:
> >
> > > > From: trawick@rdu88-250-182.nc.rr.com [mailto:trawick@rdu88-250-
> > > >
> > > > A little bird told me that FD_ZERO() burns lots of cycles in
> > > > apr_wait_for_io_or_timeout().  It turns out that this is an easy
> > > > conversion to poll(), which doesn't have such overhead in the
> > > > interface.
> > > >
> > > > This works for me with some testing (timeouts on read and write
> work
> > > > for me).
> > >
> > > Can we remove the #ifdef's by just using apr_poll here?
> >
> > I'd rather we not, since that introduces a fair amount of extra
> > overhead.
>
> Then let's get rid of the overhead.  If we don't use apr_poll, then the
> overhead is maintenance, because we have abstracted out the poll/select
> difference twice in the code.

I'd rather pay the maintenance overhead on this code. BTW, testing on AIX
yields up to a 9% increase in throughput with this patch (serving 500 byte
file out of mod_mem_cache). Huge win for a small change!

Bill


Mime
View raw message