apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Blair Zajac <bl...@orcaware.com>
Subject Re: [PATCH] apr_pools.c patch for bounds checking compiler
Date Wed, 31 Jul 2002 23:10:07 GMT
Blair Zajac wrote:
> 
> I'm using the bounds checking gcc 3.1.1 to check for memory issues
> in Apache and Subversion.  This patch to gcc compiles the code with
> extra checks for illegal memory accesses, invalid pointers, etc and
> runs a lot faster than valgrind.  See
> 
>     http://web.inter.nl.net/hcc/Haj.Ten.Brugge/
> 
> There's a core dump from the bounds checking compiler when running
> httpd -l with today's HEAD
> 

Here's an updated patch with an additional change that was caught with
Subversion's make check, replacing

-    if (!ps->got_a_new_node && node->first_avail + size < node->endp)
{

with

+    if (!ps->got_a_new_node && node->endp - node->first_avail > size)
{

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
Mime
View raw message