apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@apache.org>
Subject Re: EINVAL vs APR_EINVAL in apr_xlate_open()
Date Thu, 18 Jul 2002 22:20:03 GMT
On Thu, Jul 18, 2002 at 05:04:33PM -0500, Karl Fogel wrote:
> Well, this is *us* generating the EINVAL by fiat, not getting it from
> some lower-down system call.  
> Maybe we should still go with APR_EINVAL, on the principle of least
> surprise, though.  I'm not sure; trusting people with more APR
> experience to know a good answer here.

Right, the system is free to use EINVAL.  APR should not produce
EINVAL itself.  

I'm assuming you mean this code fragment in xlate.c:

return rv ? rv : EINVAL;

By all means that should be:

return rv ? rv : APR_EINVAL;

HTH.  -- justin

View raw message