apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: [PATCH] updated code to select default atomic ops
Date Sat, 13 Jul 2002 04:17:23 GMT
On Fri, 2002-07-12 at 20:58, Justin Erenkrantz wrote:
> On Fri, Jul 12, 2002 at 08:43:05PM -0700, Brian Pane wrote:
> > @@ -161,6 +162,7 @@
> >  
> >  #define apr_atomic_add(mem, val)     atomic_add(mem,val)
> >  APR_DECLARE(int) apr_atomic_dec(apr_atomic_t *mem);
> > +#define apr_override_atomic_dec 1
> >  #define apr_atomic_inc(mem)          atomic_inc(mem)
> >  #define apr_atomic_set(mem, val)     (*mem = val)
> >  #define apr_atomic_read(mem)         (*mem)
> 
> I'd prefer that to be APR_OVERRIDE_ATOMIC_DEC.  It's not a function.
> I think only functions should be lowercase.  -- justin

I agree; I'll switch to caps for the final version.
--Brian



Mime
View raw message