Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <rbb@covalent.net>
From: "Ryan Bloom" <rbb@covalent.net>
To: "'Greg Stein'" <gstein@lyra.org>,
	"'Branko Cibej'" <brane@xbc.nu>
Cc: "'Ben Collins-Sussman'" <sussman@collab.net>,
	"'SVN Dev List'" <dev@subversion.tigris.org>,
	<dev@apr.apache.org>
Subject: RE: repository conversion on windows fails / binary file
Date: Tue, 11 Jun 2002 15:36:34 -0700
Organization: Covalent Technologies
Message-ID: <005901c21198$70cba290$2200000a@KOJ>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Importance: Normal
In-Reply-To: <20020611153528.A21228@lyra.org>

> From: Greg Stein [mailto:gstein@lyra.org]
> 
> On Tue, Jun 11, 2002 at 10:10:22PM +0200, Branko Cibej wrote:
> >...
> > The solution is to reopen the streams in binary mode, obviously. I
> > wonder how you do that in APR.
> 
> Pass APR_BINARY to the apr_file_open() function. Not a problem.
> 
> Of course, it appears that apr/file_io/win32/open.c doesn't even look
for
> that flag :-(

That is a pretty major bug.   :-(

> 
> Hmm. And reopening stdout/stdin in binary mode... oof. No fricking
clue.

We don't do that currently.  You really only have two options as things
stand today.  1)  Close the file and re-open.  2)  Implement
apr_file_reopen (which devolves to option #1 in the worst case
scenario).

Ryan