From dev-return-6667-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Sun Jun 02 17:33:08 2002
Return-Path: <dev-return-6667-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 17404 invoked by uid 500); 2 Jun 2002 17:33:07 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Subscribe: <mailto:dev-subscribe@apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Delivered-To: moderator for dev@apr.apache.org
Received: (qmail 68334 invoked from network); 2 Jun 2002 07:26:58 -0000
Message-ID: <012801c20a07$0374f2c0$82db26cb@saxon>
From: "Saxon Druce" <saxon@blocksoftware.com>
To: <dev@apr.apache.org>
References: <20020530052500.93205.qmail@icarus.apache.org>
Subject: Re: cvs commit: apr/file_io/win32 open.c pipe.c
Date: Sun, 2 Jun 2002 15:27:54 +0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.00.2919.6700
X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N


----- Original Message -----
From: <wrowe@apache.org>
To: <apr-cvs@apache.org>
Sent: Thursday, May 30, 2002 1:25 PM
Subject: cvs commit: apr/file_io/win32 open.c pipe.c


> wrowe       02/05/29 22:25:00
>
>   Modified:    file_io/win32 open.c pipe.c
>   Log:
>     Modify our pipe semantics to match linux, such that at least 65536
bytes
>     may be written to the pipe before it deadlocks.  Matches our 1.3 fix.
>
>   PR: 8179
>
>   Revision  Changes    Path
>   1.101     +1 -0      apr/file_io/win32/open.c
>
>   Index: open.c
>   ===================================================================
>   RCS file: /home/cvs/apr/file_io/win32/open.c,v
>   retrieving revision 1.100
>   retrieving revision 1.101
>   diff -u -r1.100 -r1.101
>   --- open.c 20 Mar 2002 08:54:43 -0000 1.100
>   +++ open.c 30 May 2002 05:25:00 -0000 1.101
>   @@ -519,6 +519,7 @@
>        (*file)->filehand = *thefile;
>        (*file)->ungetchar = -1; /* no char avail */
>        (*file)->flags;
>   +    (*file)->pipe;
>        return APR_SUCCESS;
>    }

Shouldn't that be:

(*file)->pipe = <something>;

?

And the previous line should be:

(*file)->flags = flags;

(I submitted a patch for that one about 2 months ago).

cya,
Saxon Druce (saxon@blocksoftware.com)