apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: cvs commit: apr/include apr_time.h
Date Wed, 12 Jun 2002 17:06:42 GMT
On 12 Jun 2002 wrowe@apache.org wrote:

>   +#define APR_TIME_USEC(time) ((apr_int32_t)(time) % APR_USEC_PER_SEC)
>   +
>   +#define APR_TIME_SEC(time) ((apr_int64_t)(time) / APR_USEC_PER_SEC)
>   +
>   +#define APR_TIME_FROM_SEC(sec) ((apr_time_t)(sec) * APR_USEC_PER_SEC)
>   +
>   +#define APR_TIME_MAKE(sec, usec) ((apr_time_t)(sec) * APR_USEC_PER_SEC + usec)

Aren't these all missing a set of parens?  In other words, I think the
cast should occur after the division/multiplication.

Such as:

#define APR_TIME_USEC(time) ((apr_int32_t)((time) % APR_USEC_PER_SEC))

etc.  No?

--Cliff


Mime
View raw message