apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: apr/file_io/win32 open.c pipe.c
Date Mon, 03 Jun 2002 19:14:02 GMT
That's a placeholder for an decision not made (I believe we apr_pcalloc,
so it isn't a huge issue between = 0 or omitting it entirely.)

However, if we really were strict, we should call apr_file_info_get()
on the new file entity and set the pipe value based on the file type, no?

At 01:51 PM 6/3/2002, you wrote:
>"Saxon Druce" <saxon@blocksoftware.com> writes:
>
> > >   Index: open.c
> > >   ===================================================================
> > >   RCS file: /home/cvs/apr/file_io/win32/open.c,v
> > >   retrieving revision 1.100
> > >   retrieving revision 1.101
> > >   diff -u -r1.100 -r1.101
> > >   --- open.c 20 Mar 2002 08:54:43 -0000 1.100
> > >   +++ open.c 30 May 2002 05:25:00 -0000 1.101
> > >   @@ -519,6 +519,7 @@
> > >        (*file)->filehand = *thefile;
> > >        (*file)->ungetchar = -1; /* no char avail */
> > >        (*file)->flags;
> > >   +    (*file)->pipe;
> > >        return APR_SUCCESS;
> > >    }
> >
> > Shouldn't that be:
> >
> > (*file)->pipe = <something>;
>
>Definitely should be changed, even though it works fine now.
>apr_os_file_put() assumes that it is a pipe, so it should be
>
>   (*file)->pipe = 0;
>
>or the code can simply be omitted since the structure is cleared.
>
> > And the previous line should be:
> >
> > (*file)->flags = flags;
> >
> > (I submitted a patch for that one about 2 months ago).
>
>if no Win32 committer speaks up/commits soon, I'll do it myself,
>albeit with no test-compile
>
>Thanks for persisting!!!!!
>
>--
>Jeff Trawick | trawick@attglobal.net
>Born in Roswell... married an alien...



Mime
View raw message