apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: [PATCH] Re: 2.0 performance Re: Breaking something? Now is the time?
Date Sat, 29 Jun 2002 20:47:38 GMT
Cliff Woolley wrote:

>On Sat, 29 Jun 2002, Brian Pane wrote:
>
>  
>
>>I tried this, and it didn't unroll the loop.  That's probably
>>because some of information needed to unroll the loop effectively
>>is unknown to the compiler.
>>    
>>
>
>Hm.  Okay, well, if we're going to do this, can we split it out into a
>separate macro (my_strncpy or something) so it's clear what's going on and
>to avoid cluttering up that function?
>

I have reservations about making it a macro, because that would
confuse debuggers and any profilers that do basic-block or line-level
profiling.

I also don't mind cluttering the function.  The value of
a low-level I/O API like apr_brigade_puts() is that it hides
ugly bufer management details from application code, so that
the application code can stay clean and simple.

--Brian



Mime
View raw message