apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject [PATCH] Re: 2.0 performance Re: Breaking something? Now is the time?
Date Sat, 29 Jun 2002 04:52:33 GMT
Brian Pane wrote:

> Bill Stoddard wrote:
> ...

>> The time spent in ap_brigade_puts is
>> suprising...  This particular run indicate that it tool 74355 
>> instructions
>> to serve a keep alive request.
> I've seen the brigade_puts overhead in my testing, too...and it
> is definitely surprising, since the code is relatively minimal.
> The only obvious (potential) speedup I can think of would be to
> replace the char-at-a-time loop with a memcpy (with checks to
> make sure it doesn't overflow the available size).  I'll try this
> over the weekend. 

I remembered why memcpy won't help here: we don't know the
length in advance.  But I managed to speed up apr_brigade_puts()
by about 30% in my tests by optimizing its main loop.  Does this
patch reduce the apr_brigade_puts() overhead in your test environment?


View raw message