apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saxon Druce" <sa...@blocksoftware.com>
Subject Re: cvs commit: apr/file_io/win32 open.c pipe.c
Date Sun, 02 Jun 2002 07:27:54 GMT

----- Original Message -----
From: <wrowe@apache.org>
To: <apr-cvs@apache.org>
Sent: Thursday, May 30, 2002 1:25 PM
Subject: cvs commit: apr/file_io/win32 open.c pipe.c


> wrowe       02/05/29 22:25:00
>
>   Modified:    file_io/win32 open.c pipe.c
>   Log:
>     Modify our pipe semantics to match linux, such that at least 65536
bytes
>     may be written to the pipe before it deadlocks.  Matches our 1.3 fix.
>
>   PR: 8179
>
>   Revision  Changes    Path
>   1.101     +1 -0      apr/file_io/win32/open.c
>
>   Index: open.c
>   ===================================================================
>   RCS file: /home/cvs/apr/file_io/win32/open.c,v
>   retrieving revision 1.100
>   retrieving revision 1.101
>   diff -u -r1.100 -r1.101
>   --- open.c 20 Mar 2002 08:54:43 -0000 1.100
>   +++ open.c 30 May 2002 05:25:00 -0000 1.101
>   @@ -519,6 +519,7 @@
>        (*file)->filehand = *thefile;
>        (*file)->ungetchar = -1; /* no char avail */
>        (*file)->flags;
>   +    (*file)->pipe;
>        return APR_SUCCESS;
>    }

Shouldn't that be:

(*file)->pipe = <something>;

?

And the previous line should be:

(*file)->flags = flags;

(I submitted a patch for that one about 2 months ago).

cya,
Saxon Druce (saxon@blocksoftware.com)




Mime
View raw message