Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
From: "Sander Striker" <striker@apache.org>
To: "Branko Cibej" <brane@xbc.nu>
Cc: <dev@subversion.tigris.org>, <dev@apr.apache.org>
Subject: RE: build error on win32
Date: Wed, 29 May 2002 22:14:33 +0200
Message-ID: <JLEGKKNELMHCJPNMOKHOKEEAFPAA.striker@apache.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <3CF532BD.7010009@xbc.nu>
Importance: Normal

> From: Branko Cibej [mailto:brane@xbc.nu]
> Sent: 29 May 2002 21:58

> Branko =C4=8Cibej wrote:
>=20
>> Patrik Husfloen wrote:
>>
>>> I'm getting an error building svn on win32 using VC6.
>>> I've got the latest version of apr, apr-util and svn (just got them=20
>>> from cvs/svn)
>>> if anyone can confirm this it would be great.
>>>
>>> libsvn_subr.lib(svn_error.obj) : error LNK2001: unresolved external=20
>>> symbol _apr_allocator_set_mutex@8
>>> Release/svn.exe : fatal error LNK1120: 1 unresolved externals
>>
>>
>> This looks like a bug in APR. Both apr_allocator_set_mutex and=20
>> apr_allocator_get_mutex are defined with APR_INLINE in apr_pools.c,=20
>> which is clearly major bogosity. Either that APR_INLINE shoudl go=20
>> away, or the inline definitions should move to a header (probably=20
>> apr_allocator.h, where they're declared now), and made static.
>>
>> Sander, looks like you're the culprit here (the rev 1.159 commit).=20
>> Comments?
>=20
> While we're at it, apr_allocator_alloc and apr_allocator_free are also =

> defined inline. I don't think that makes much sense, given the size of =

> those functions.

Hmm, so windows isn't smart enough to do both inlining and exporting?
I'd like the stuff inlined in apr_pools.c (for performance), but need
them exported for other callers than apr_pools.c.

Suggestions?

Sander