From dev-return-6658-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri May 31 21:01:19 2002 Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 24789 invoked by uid 500); 31 May 2002 21:01:18 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 24778 invoked from network); 31 May 2002 21:01:18 -0000 Date: Fri, 31 May 2002 16:57:51 -0400 (EDT) From: Cliff Woolley X-X-Sender: root@deepthought.cs.virginia.edu To: dev@apr.apache.org Subject: Re: cvs commit: apr-util/include apr_buckets.h In-Reply-To: <20020531205120.39266.qmail@icarus.apache.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On 31 May 2002 rbb@apache.org wrote: > rbb 2002/05/31 13:51:20 > > Modified: buckets apr_buckets_eos.c apr_buckets_file.c > apr_buckets_flush.c apr_buckets_heap.c > apr_buckets_mmap.c apr_buckets_pipe.c > apr_buckets_pool.c apr_buckets_socket.c > include apr_buckets.h > Log: > Make buckets advertise if they are filled with metadata or not. > Long-term, we most likely want to extend this so that buckets can have > more states than just "data" or "metadata". For now, this is enough. I'd much rather see this flag be in the apr_bucket_type_t than in the apr_bucket. As it is now, not only is it one more thing to have to set at runtime, we'll now have to worry about making sure it's set right if we want to morph. --Cliff