apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject apr_brigade_write() [was Re: cvs commit: apr-util/buckets apr_brigade.c]
Date Thu, 23 May 2002 21:21:25 GMT
On Thu, 23 May 2002, Cliff Woolley wrote:

> > At some point, apr_brigade_write() got broken. When the HEAP bucket at the
> > end of the brigade fills up, the flush function should be called. The
> > current code allocates *another* heap bucket. With this logic, it is
> > possible to grow a brigade without any periodic flushing. *very* bad.
> That could be my fault from when I got rid of the awful awful beast that
> was check_brigade_flush().  I *thought* I was very careful to keep the
> exact semantics, but I might have missed this case.  I'll take another
> look at it.

Hmmm... when SVN calls apr_brigade_write(), does it provide a flush
function or not?  Where in SVN is this, so I can take a closer look?


View raw message