apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: cvs commit: apr-util/strmatch apr_strmatch.c
Date Fri, 24 May 2002 14:21:46 GMT
Jeff Trawick wrote:

>Jeff Trawick <trawick@attglobal.net> writes:
>
>  
>
>>brianp@apache.org writes:
>>
>>    
>>
>>>brianp      02/05/23 18:07:47
>>>
>>>  Modified:    strmatch apr_strmatch.c
>>>  Log:
>>>  Switched to unsigned chars in the searching functions to avoid
>>>  problems when input strings contain character values > 127
>>>  Reported by: Cliff Woolley
>>>      
>>>
>>ouch, lots of compile errors with native compiler on AIX (invalid
>>operations between pointers to char of different signed-ness)
>>
>>I'll start playing with this in a minute...
>>    
>>
>
>I guess this patch is appropriate unless we want to change the API.
>Darn signed chars :)
>

There's only one operation in the whole algorithm that
really needs an unsigned char.  I'll switch back to signed
chars, with a cast to unsigned only in the case where the
char value is used as an array index.

--Brian



Mime
View raw message