apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr-util/buckets apr_brigade.c
Date Thu, 23 May 2002 21:44:28 GMT
On Thu, May 23, 2002 at 05:13:22PM -0400, Cliff Woolley wrote:
> On Thu, 23 May 2002, Greg Stein wrote:
>...
> > At some point, apr_brigade_write() got broken. When the HEAP bucket at the
> > end of the brigade fills up, the flush function should be called. The
> > current code allocates *another* heap bucket. With this logic, it is
> > possible to grow a brigade without any periodic flushing. *very* bad.
> 
> That could be my fault from when I got rid of the awful awful beast that
> was check_brigade_flush().

Yes, that was definitely a bastard of a function. Even after I fixed it up
some :-)  I suspected that was when the semantics got tweaked, but figured
it was enough to just explain the problem.

[ and no, we won't mention that Ryan wrote it in the first place :-) ]

> I *thought* I was very careful to keep the
> exact semantics, but I might have missed this case.

Easy enough to do. No permanent harm done :-)

> I'll take another look at it.

Cool! Thanks!

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message