apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <...@covalent.net>
Subject RE: cvs commit: apr-util/buckets apr_brigade.c
Date Thu, 23 May 2002 21:44:21 GMT

> From: Greg Stein [mailto:gstein@lyra.org]
> 
> On Thu, May 23, 2002 at 05:13:22PM -0400, Cliff Woolley wrote:
> > On Thu, 23 May 2002, Greg Stein wrote:
> >...
> > > At some point, apr_brigade_write() got broken. When the HEAP
bucket at
> the
> > > end of the brigade fills up, the flush function should be called.
The
> > > current code allocates *another* heap bucket. With this logic, it
is
> > > possible to grow a brigade without any periodic flushing. *very*
bad.
> >
> > That could be my fault from when I got rid of the awful awful beast
that
> > was check_brigade_flush().
> 
> Yes, that was definitely a bastard of a function. Even after I fixed
it up
> some :-)  I suspected that was when the semantics got tweaked, but
figured
> it was enough to just explain the problem.
> 
> [ and no, we won't mention that Ryan wrote it in the first place :-) ]

Hey, it got the job done.   :-)

Ryan



Mime
View raw message