apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject Re: cvs commit: apr-util/buckets apr_brigade.c
Date Tue, 14 May 2002 13:16:18 GMT

> > At the same time, the brigade_write() family can be tricky to maintain at
> > times.  It's much better than it used to be (now that
> > check_brigade_flush() has been burned at the stake), though.
> >
> > So the real question is this: is it ever possible for strlen()+memcpy() to
> > be faster than the while loop used here?  I believe the answer is no.
> I think the answer is yes :-)  Thus, my request for actual numbers.
> We really cannot continue to add complexity to the codebase every time we
> want another 1% improvement. We'll end up with an unmaintainable codebase;
> it'll run wicked fast, but we won't be able to fix or improve it.
> Cheers,
> -g

Yes, I completely agree with Greg. If the optimization is not obvious for what it is (an
optimization), then we should live without it.


View raw message