From dev-return-5940-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Sat Mar 09 14:10:34 2002
Return-Path: <dev-return-5940-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 58575 invoked by uid 500); 9 Mar 2002 14:10:33 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Subscribe: <mailto:dev-subscribe@apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 58562 invoked from network); 9 Mar 2002 14:10:33 -0000
From: "Sander Striker" <striker@apache.org>
To: <dev@httpd.apache.org>
Cc: <dev@apr.apache.org>
Subject: RE: cvs commit: httpd-2.0/modules/proxy mod_proxy.c
Date: Sat, 9 Mar 2002 15:15:36 +0100
Message-ID: <JLEGKKNELMHCJPNMOKHOIELGFHAA.striker@apache.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0)
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200
In-Reply-To: <20020309140411.19434.qmail@icarus.apache.org>
Importance: Normal
X-Rcpt-To: <dev@apr.apache.org>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

> From: trawick@apache.org [mailto:trawick@apache.org]
> Sent: 09 March 2002 15:04

> trawick     02/03/09 06:04:11
> 
>   Modified:    modules/proxy mod_proxy.c
>   Log:
>   provide missing MAX() macro so that proxy can compile again
>   
>   Revision  Changes    Path
>   1.74      +3 -0      httpd-2.0/modules/proxy/mod_proxy.c
>   
>   Index: mod_proxy.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/proxy/mod_proxy.c,v
>   retrieving revision 1.73
>   retrieving revision 1.74
>   diff -u -r1.73 -r1.74
>   --- mod_proxy.c	9 Mar 2002 07:15:33 -0000	1.73
>   +++ mod_proxy.c	9 Mar 2002 14:04:11 -0000	1.74
>   @@ -63,6 +63,9 @@
>    
>    extern module AP_MODULE_DECLARE_DATA proxy_module;
>    
>   +#ifndef MAX
>   +#define MAX(x,y) ((x) >= (y) ? (x) : (y))
>   +#endif
>    
>    /*
>     * A Web proxy module. Stages:

This seems like a common enough thing to deserve a place in APR.
We can do it like we handle some of the string functions*, or
we can define an APR_MAX, APR_MIN, etc.

Thoughts?

Sander

*) define them if they are not present