From dev-return-5934-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Mar 07 23:20:48 2002 Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 97653 invoked by uid 500); 7 Mar 2002 23:20:47 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 97642 invoked from network); 7 Mar 2002 23:20:47 -0000 Errors-To: Message-Id: <5.1.0.14.2.20020307164305.00bb1ec8@localhost> X-Sender: wrowe%rowe-clan.net/pop3.rowe-clan.net@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Thu, 07 Mar 2002 16:45:02 -0600 To: Dale Ghent ;, dev@apr.apache.org From: "William A. Rowe, Jr." Subject: Re: [PATCH] Re: large file support (was: Re: Memory comsumption of svn) In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N At 12:05 PM 3/7/2002, you wrote: >On 7 Mar 2002, Jeff Trawick wrote: > >| Any reason this didn't get committed? > >If everyone likes this general framework, I can do research and get more >OSes that have largefile support added into that patch, besides just >having Solaris >= 2.6 enabled. > >Also, I know (Greg? Bill?)) was saying something about APR_HAS_LARGEFILES >or something of the sort. A grep through the unix tree doesnt show that >symbol, but is this something that's really needed? I'm of the opinion >that largefile support exists below the APR layer, and any OS-specific >compile flags are saved to apxs in Apache-land... any other thoughts on >this? APR_HAS_LARGEFILES tells us that files don't fit in memory (and that apr_size_t is not equivalent to apr_off_t.) This affects code in several places, it's critical we note it. For example, we 'know' we aren't allowed to sendfile() files bigger than memory allows, so we split sendfiles into units (16MB each, in apache) for transmission. mmap and other users will have similar concerns. Bill