apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] Adding an apr_utime() function
Date Thu, 14 Mar 2002 18:53:46 GMT
"Robert Simonson" <simo@us.ibm.com> writes:

> This patch adds apr_utime() to the APR.  I did this against the unix
> directories.

A missing piece for unix is detecting the presence of utime.h and
setting the utimeh variable.  I think you just need to add utime.h to
the APR_FLAG_HEADERS invocation in configure.in, then add an
AC_SUBST(utimeh) invocation with the rest of them.

> I don't know how this affects (if at all) other platforms.

If somebody cares they will implement; if not, then it will be missing
until somebody starts caring.  I wonder if a feature test macro is
needed.  Initially we'd need to set APR_HAVE_UTIME_H to 0 in apr.hw
(Win32) and apr.hnw (Netware).

As far as the name apr_utime(): 

  no freakin' way :)  I'd suggest something like apr_file_time_set().

As far as which times to set (atime, ctime, mtime):

  I don't care about ctime either.  I wonder if anybody else cares.

As far as how to specify those times:

  I'd vote for separate parameters instead of stuffing them in a
  structure.  I don't see the benefit to the structure.

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...

Mime
View raw message