apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] fix alignment on shared memory
Date Fri, 01 Mar 2002 18:42:12 GMT
Cliff Woolley <jwoolley@virginia.edu> writes:

> On Fri, 1 Mar 2002, Aaron Bannert wrote:
> > Yes, I completely agree that each structure needs to be 64-bit aligned.
> > I don't see how the shared memory code itself is incorrect. It must be
> > mapping the segment at a properly aligned boundary, so as long as the
> > contents of that segment are accessed in an aligned manner than we're
> > safe, right?
> That's what I'm thinking, too.  I don't see the problem there.  It looks
> to me like you (Aaron) were right on when you suggested that it's
> ap_calc_scoreboard_size() and ap_init_scoreboard()'s fault.  Try this, for
> example:

Jeff calling Cliff and Aaron: apr_shm_baseaddr_get() returns
addresses which aren't 64-bit aligned.  That is broken.  End of story.

Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
             Born in Roswell... married an alien...

View raw message