apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sander Striker" <stri...@apache.org>
Subject RE: [PATCH] First cut at factoring out the pools allocator
Date Wed, 13 Mar 2002 15:06:02 GMT
> From: Brian Pane [mailto:brian.pane@cnet.com]
> Sent: 13 March 2002 15:59

> Justin Erenkrantz wrote:
> 
> >On Tue, Mar 05, 2002 at 10:02:55AM +0100, Sander Striker wrote:
> >
> >>Hi,
> >>
> >>Below a patch to apr and a patch to httpd
> >>to factor out the allocator from pools.  It
> >>is only the first cut, so crucial details
> >>like documentation are missing.
> >>
> >>I'd like some feedback on the general idea
> >>though.
> >>
> >>Hopefully this helps when implementing the
> >>bucket allocator.
> >>
> >
> >+1.  I like the API.  Brian's suggestion is goodness, but shouldn't
> >stop this from going in.
> >
> 
> +1.  I think we'll need to implement my suggestion (a variant
> of the allocation function that reserves space for the internal
> header struct but still stays within 8KB) in support of the
> bucket free lists, but that that's a simple, additive change
> that we can put in later--so +1 on committing Sander's new
> allocator API now.

Ok, I'll try and get it in tonight.

I'm not entirely sure we need the extra allocation function though,
but we can decide on that later.

Sander

Mime
View raw message