apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: cvs commit: apr/build apr_common.m4
Date Thu, 14 Mar 2002 02:50:43 GMT
On Wed, 13 Mar 2002 20:41:12 -0500 (EST), Jim Jagielski wrote:

>Weird... I'm guessing you don't have problems with the other
>usages of ${}... $3 should be special enough not to require.
>I'll back this out since shells that *don't* support it
>are more broken :)

Thanks (wow, that was quick :)
Isn't it an M4 expansion that's going on here though? The $3 represents the
third parameter to the APR_PATH_RELATIVE M4 macro, not to the shell script.



>Brian Havard wrote:
>> 
>> On 13 Mar 2002 18:13:02 -0000, jim@apache.org wrote:
>> 
>> >jim         02/03/13 10:13:02
>> >
>> >  Modified:    build    apr_common.m4
>> >  Log:
>> >  Fix weird error report... not sure what
>> >  brain damaged shell would misinterpret the current method, but
>> >  this safes it.
>> >  
>> >  Revision  Changes    Path
>> >  1.26      +1 -1      apr/build/apr_common.m4
>> >  
>> >  Index: apr_common.m4
>> >  ===================================================================
>> >  RCS file: /home/cvs/apr/build/apr_common.m4,v
>> >  retrieving revision 1.25
>> >  retrieving revision 1.26
>> >  diff -u -r1.25 -r1.26
>> >  --- apr_common.m4	8 Mar 2002 17:56:14 -0000	1.25
>> >  +++ apr_common.m4	13 Mar 2002 18:13:02 -0000	1.26
>> >  @@ -589,7 +589,7 @@
>> >   dnl APR_PATH_RELATIVE(final_path, $orig_path, $prefix)
>> >   dnl    $final_path now contains "bar"
>> >   AC_DEFUN(APR_PATH_RELATIVE,[
>> >  -stripped=`echo $2 | sed -e "s#^$3##"`
>> >  +stripped=`echo $2 | sed -e "s#^${3}##"`
>> >   # check if the stripping was successful
>> >   if test "x$2" != "x$stripped"; then
>> >       # it was, so strip of any leading slashes
>> 
>> Unfortuntely that breaks it for me. The generated code in Apache's
>> configure changes from:
>> 
>> stripped=`echo $ap_sysconfdir | sed -e "s#^$prefix##"`
>> 
>> to
>> 
>> stripped=`echo $ap_sysconfdir | sed -e "s#^${3}##"`
>> 
>> which is obviously wrong & I end up with an absolute SERVER_CONFIG_FILE
>> again.

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message