Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 46354 invoked by uid 500); 3 Feb 2002 01:34:45 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 46330 invoked from network); 3 Feb 2002 01:34:45 -0000 Date: Sat, 2 Feb 2002 20:34:32 -0500 (EST) From: Cliff Woolley X-X-Sender: To: Kevin Pilch-Bisson cc: Philip Martin , , Subject: Re: [PATCH] APR turn off readonly/executable, add apr_file_attrs_get In-Reply-To: <20020203012813.GA24501@pilch-bisson.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sat, 2 Feb 2002, Kevin Pilch-Bisson wrote: > On Sat, Feb 02, 2002 at 08:34:44PM +0000, Philip Martin wrote: > > +#ifdef APR_HAS_THREADS > > + status = apr_thread_mutex_lock(umask_mutex); > > + if (!APR_STATUS_IS_SUCCESS(status)) > > + return status; > > +#endif > > Shouldn't this be > #if APR_HAS_THREADS > > i.e. isn't it always defined to either 0 or 1. Yes, it should be. --Cliff -------------------------------------------------------------- Cliff Woolley cliffwoolley@yahoo.com Charlottesville, VA