From dev-return-5732-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Feb 13 02:18:21 2002 Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 78707 invoked by uid 500); 13 Feb 2002 02:18:20 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 78696 invoked from network); 13 Feb 2002 02:18:20 -0000 Message-ID: <033701c1b434$8f525040$94c0b0d0@v505> From: "William A. Rowe, Jr." To: "Greg Stein" , , "Mladen Turk" References: <20020212215613.23122.qmail@icarus.apache.org> <20020212170755.J7900@lyra.org> Subject: Re: cvs commit: apr/misc/win32 getuuid.c Date: Tue, 12 Feb 2002 20:10:26 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4522.1200 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 X-OriginalArrivalTime: 13 Feb 2002 02:17:17.0892 (UTC) FILETIME=[8F525040:01C1B434] X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N +1, Agreed and backed out. Mladen - would you substitute the misc/unix implementation and report back with a patch to that file only, if a patch is required? Otherwise, just the updated build files [zipped as you had them] would be great. Bill ----- Original Message ----- From: "Greg Stein" To: Sent: Tuesday, February 12, 2002 7:07 PM Subject: Re: cvs commit: apr/misc/win32 getuuid.c > -1 > > The code should defer to the Unix version of getuuid.c. That has a much more > robust implementation. > > Cheers, > -g > > On Tue, Feb 12, 2002 at 09:56:13PM -0000, wrowe@apache.org wrote: > >... > > --- getuuid.c 13 Apr 2001 15:31:31 -0000 1.6 > > +++ getuuid.c 12 Feb 2002 21:56:13 -0000 1.7 > > @@ -76,6 +76,16 @@ > > * is therefore not only a uniqifier, but an identity (which might not > > * be appropriate in all cases. > > */ > > +#ifndef _WIN32_WCE > > (void) CoCreateGuid(&guid); > > +#else > > + /* WCE lacks CoCreateGuid. So make something simple > > + * for now. > > + */ > > + guid.Data1 = rand(); > > + guid.Data2 = rand(); > > + guid.Data3 = rand(); > > + sprintf(guid.Data4, "%08X", rand()); > > +#endif > > memcpy(uuid->data, &guid, sizeof(uuid->data)); > > } > > -- > Greg Stein, http://www.lyra.org/ >