apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: apr/include apr_file_info.h apr_file_io.h
Date Fri, 01 Feb 2002 13:17:09 GMT
gstein@apache.org writes:

> gstein      02/01/31 17:40:39
> 
>   Modified:    .        libapr.dsp
>                file_io/unix Makefile.in filestat.c
>                file_io/win32 filestat.c
>                include  apr_file_info.h apr_file_io.h
>   Log:
...
>   Also add apr_file_attrs_set() for setting file attributes in a logical
>   fashion, rather than based on (Posix) permission bits. This is not
>   (yet) implemented for Windows, and still needs a way to turn *off* the
>   readonly and executable modes.
...
>   Index: apr_file_info.h
>   ===================================================================
>   RCS file: /home/cvs/apr/include/apr_file_info.h,v
>   retrieving revision 1.24
>   retrieving revision 1.25
>   diff -u -r1.24 -r1.25
>   --- apr_file_info.h	9 Sep 2001 06:03:05 -0000	1.24
>   +++ apr_file_info.h	1 Feb 2002 01:40:38 -0000	1.25
>   @@ -94,20 +94,25 @@
>     * @{
>     */
>    
>   -#define APR_UREAD     0x400 /**< Read by user */
>   -#define APR_UWRITE    0x200 /**< Write by user */
>   -#define APR_UEXECUTE  0x100 /**< Execute by user */
>   -
>   -#define APR_GREAD     0x040 /**< Read by group */
>   -#define APR_GWRITE    0x020 /**< Write by group */
>   -#define APR_GEXECUTE  0x010 /**< Execute by group */
>   -
>   -#define APR_WREAD     0x004 /**< Read by others */
>   -#define APR_WWRITE    0x002 /**< Write by others */
>   -#define APR_WEXECUTE  0x001 /**< Execute by others */
>   +#define APR_UREAD       0x4000 /**< Read by user */
>   +#define APR_UWRITE      0x2000 /**< Write by user */
>   +#define APR_UEXECUTE    0x1000 /**< Execute by user */
>   +
>   +#define APR_GREAD       0x0040 /**< Read by group */
>   +#define APR_GWRITE      0x0020 /**< Write by group */
>   +#define APR_GEXECUTE    0x0010 /**< Execute by group */
>   +
>   +#define APR_WREAD       0x0004 /**< Read by others */
>   +#define APR_WWRITE      0x0002 /**< Write by others */
>   +#define APR_WEXECUTE    0x0001 /**< Execute by others */
>   +
>   +#define APR_OS_DEFAULT  0x0FFF /**< use OS's default permissions */

Shouldn't APR_OS_DEFAULT have been changed to 0xFFFF with this?  It no
longer works.  Try to run testdir more than once.  Try to run
buildconf after running testdir.  testdir says perms should be
APR_OS_DEFAULT.  The perms on the created directory end up being 055.

Hopefully I'll get time to play with it later today...  but
confirmation in advance is always nice :)

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message