apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <phi...@codematters.co.uk>
Subject Re: [PATCH] APR turn off readonly/executable, add apr_file_attrs_get
Date Sun, 03 Feb 2002 02:03:12 GMT
Cliff Woolley <cliffwoolley@yahoo.com> writes:

> On Sat, 2 Feb 2002, Kevin Pilch-Bisson wrote:
> 
> > On Sat, Feb 02, 2002 at 08:34:44PM +0000, Philip Martin wrote:
> > > +#ifdef APR_HAS_THREADS
> > > +    status = apr_thread_mutex_lock(umask_mutex);
> > > +    if (!APR_STATUS_IS_SUCCESS(status))
> > > +        return status;
> > > +#endif
> >
> > Shouldn't this be
> > #if APR_HAS_THREADS
> >
> > i.e. isn't it always defined to either 0 or 1.
> 
> 
> Yes, it should be.

OK. I can make the mutex creation conditional as well.

-- 
Philip

Mime
View raw message