apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@clove.org>
Subject Re: cvs commit: apr/locks/netware global_mutex.c
Date Thu, 21 Feb 2002 00:32:36 GMT
On Wed, Feb 20, 2002 at 06:23:05PM -0600, William Rowe wrote:
> > These are implementation details, so I don't see why they need to be
> > defined globally (in apr.h, if I'm understanding you correctly). I do
> > agree, however, that the extra function call is unnecessary. Can we use
> > APR_INLINE? An alternative would be to #define APR_PROC_MUTEX_IS_GLOBAL
> > in the include/arch/<foo>/proc_mutex.h and let that dictate how
> > global_mutex.c is implemented per platform (or in the default impl.).
> 
> Name, please, one place where APR_INLINE actually inlines squat today.

It was merely a suggestion. I don't have any idea of APR_INLINE actually
works.

I did provide an alternative solution, which I think is more like what
you were talking about but doesn't require a #define in apr.h.

-aaron

Mime
View raw message