apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: Apply these patches
Date Thu, 14 Feb 2002 07:47:39 GMT
On Wed, Feb 13, 2002 at 11:40:47PM -0800, Blair Zajac wrote:
> Hello,
> 
> I sent in two patches last Friday to fix/modify APRs behavior with autoconf
> 2.52{f,g}.  Can somebody apply one or both of them?  The subjects are
> 
>     [PATCH] build/buildcheck.sh: Do not accept autoconf 2.52f or greater
> 
>     [PATCH] Enabloe autoconf 2.52{f,g} builds

Your second patch did more than just enabling autoconf 2.52{f,g}
builds.  It also did a style reformat which made it hard to see
what you really changed.  While a style reformat is often good,
we request that all style changes are separate from functional
changes.

Please re-submit a patch that only enables autoconf 2.52f+ and we
can review it.  It also doesn't help that I'm probably the person
who would normally review this sort of thing and I've been busy
trying to get .32 out the door.  -- justin


Mime
View raw message