apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/misc/win32 getuuid.c
Date Wed, 13 Feb 2002 01:07:56 GMT
-1

The code should defer to the Unix version of getuuid.c. That has a much more
robust implementation.

Cheers,
-g

On Tue, Feb 12, 2002 at 09:56:13PM -0000, wrowe@apache.org wrote:
>...
>   --- getuuid.c	13 Apr 2001 15:31:31 -0000	1.6
>   +++ getuuid.c	12 Feb 2002 21:56:13 -0000	1.7
>   @@ -76,6 +76,16 @@
>         * is therefore not only a uniqifier, but an identity (which might not
>         * be appropriate in all cases.
>         */
>   +#ifndef _WIN32_WCE
>        (void) CoCreateGuid(&guid);
>   +#else
>   +    /* WCE lacks CoCreateGuid. So make something simple
>   +     * for now.
>   +     */ 
>   +    guid.Data1 = rand();
>   +    guid.Data2 = rand();
>   +    guid.Data3 = rand();
>   +    sprintf(guid.Data4, "%08X", rand());
>   +#endif
>        memcpy(uuid->data, &guid, sizeof(uuid->data));
>    }

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message