apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: cvs commit: apr/misc/win32 getuuid.c
Date Wed, 13 Feb 2002 02:10:26 GMT
+1, Agreed and backed out.

Mladen - would you substitute the misc/unix implementation and report back
with a patch to that file only, if a patch is required?  Otherwise, just
the updated build files [zipped as you had them] would be great.

Bill

----- Original Message ----- 
From: "Greg Stein" <gstein@lyra.org>
To: <dev@apr.apache.org>
Sent: Tuesday, February 12, 2002 7:07 PM
Subject: Re: cvs commit: apr/misc/win32 getuuid.c


> -1
> 
> The code should defer to the Unix version of getuuid.c. That has a much more
> robust implementation.
> 
> Cheers,
> -g
> 
> On Tue, Feb 12, 2002 at 09:56:13PM -0000, wrowe@apache.org wrote:
> >...
> >   --- getuuid.c 13 Apr 2001 15:31:31 -0000 1.6
> >   +++ getuuid.c 12 Feb 2002 21:56:13 -0000 1.7
> >   @@ -76,6 +76,16 @@
> >         * is therefore not only a uniqifier, but an identity (which might not
> >         * be appropriate in all cases.
> >         */
> >   +#ifndef _WIN32_WCE
> >        (void) CoCreateGuid(&guid);
> >   +#else
> >   +    /* WCE lacks CoCreateGuid. So make something simple
> >   +     * for now.
> >   +     */ 
> >   +    guid.Data1 = rand();
> >   +    guid.Data2 = rand();
> >   +    guid.Data3 = rand();
> >   +    sprintf(guid.Data4, "%08X", rand());
> >   +#endif
> >        memcpy(uuid->data, &guid, sizeof(uuid->data));
> >    }
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 


Mime
View raw message