Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 29 Jan 2002 12:35:53 -0800
From: Greg Stein <gstein@lyra.org>
To: "William A. Rowe, Jr." <wrowe@covalent.net>
Cc: dev@apr.apache.org
Subject: Re: [PATCH] APR WCE
Message-ID: <20020129123553.P13142@lyra.org>
Mail-Followup-To: "William A. Rowe, Jr." <wrowe@covalent.net>,
	dev@apr.apache.org
References: <002a01c1a845$a00c1240$2489bfd5@armada>
 <026e01c1a896$431169e0$94c0b0d0@v505> <20020129035022.F12675@lyra.org>
 <030e01c1a8d0$31200310$94c0b0d0@v505> <20020129113842.L13142@lyra.org>
 <058201c1a8ff$74b99210$94c0b0d0@v505>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <058201c1a8ff$74b99210$94c0b0d0@v505>;
 from wrowe@covalent.net on Tue, Jan 29, 2002 at 01:59:00PM -0600

On Tue, Jan 29, 2002 at 01:59:00PM -0600, William A. Rowe, Jr. wrote:
> From: "Greg Stein" <gstein@lyra.org>
> Sent: Tuesday, January 29, 2002 1:38 PM
> 
> 
> > Bill. Stop and think for a moment.
> > 
> > HAVE_FOO created problems because *we* defined that symbol.
> > 
> > _MSC_VER is not *defined* by us. We're just looking for it.
> > 
> > Thus, it is acceptable to *check* for it. Not to define, but to *check*.
> 
> Then to be robust and useful;
> 
> #if defined(WIN32) && defined(_MSC_VER) 
> 
> is entirely safe by me.  With that, I'm agreed, even in the public .h's :)


Ahem. "Overkill"

:-)

We do a lot of testing of platform-specific symbols without additional
annotations of the platform. But hey... it doesn't bother me if you want to
add that.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/