Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 54887 invoked by uid 500); 29 Jan 2002 19:34:08 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 54876 invoked from network); 29 Jan 2002 19:34:08 -0000 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Tue, 29 Jan 2002 11:38:42 -0800 From: Greg Stein To: "William A. Rowe, Jr." Cc: dev@apr.apache.org Subject: Re: [PATCH] APR WCE Message-ID: <20020129113842.L13142@lyra.org> Mail-Followup-To: "William A. Rowe, Jr." , dev@apr.apache.org References: <002a01c1a845$a00c1240$2489bfd5@armada> <026e01c1a896$431169e0$94c0b0d0@v505> <20020129035022.F12675@lyra.org> <030e01c1a8d0$31200310$94c0b0d0@v505> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <030e01c1a8d0$31200310$94c0b0d0@v505>; from wrowe@covalent.net on Tue, Jan 29, 2002 at 08:18:46AM -0600 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Tue, Jan 29, 2002 at 08:18:46AM -0600, William A. Rowe, Jr. wrote: > From: "Greg Stein" > Sent: Tuesday, January 29, 2002 5:50 AM >... > > On Tue, Jan 29, 2002 at 01:25:33AM -0600, William A. Rowe, Jr. wrote: >... > > > _MSC_VER is not namespace protected for APR, and apr_general.h is included > > > > _MSC_VER doesn't have to be namespace protected. He's only testing for it > > (to see if the compiler sets it). Why would it have to be protected? > > For the same reason as HAVE_FOO must be protected using buildconf, etc. Bill. Stop and think for a moment. HAVE_FOO created problems because *we* defined that symbol. _MSC_VER is not *defined* by us. We're just looking for it. Thus, it is acceptable to *check* for it. Not to define, but to *check*. Clear? Cheers, -g -- Greg Stein, http://www.lyra.org/