Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 78641 invoked by uid 500); 29 Jan 2002 20:00:21 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 78555 invoked from network); 29 Jan 2002 20:00:20 -0000 Message-ID: <058201c1a8ff$74b99210$94c0b0d0@v505> From: "William A. Rowe, Jr." To: "Greg Stein" Cc: References: <002a01c1a845$a00c1240$2489bfd5@armada> <026e01c1a896$431169e0$94c0b0d0@v505> <20020129035022.F12675@lyra.org> <030e01c1a8d0$31200310$94c0b0d0@v505> <20020129113842.L13142@lyra.org> Subject: Re: [PATCH] APR WCE Date: Tue, 29 Jan 2002 13:59:00 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4522.1200 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 X-OriginalArrivalTime: 29 Jan 2002 19:59:27.0153 (UTC) FILETIME=[74B99210:01C1A8FF] X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N From: "Greg Stein" Sent: Tuesday, January 29, 2002 1:38 PM > Bill. Stop and think for a moment. > > HAVE_FOO created problems because *we* defined that symbol. > > _MSC_VER is not *defined* by us. We're just looking for it. > > Thus, it is acceptable to *check* for it. Not to define, but to *check*. Then to be robust and useful; #if defined(WIN32) && defined(_MSC_VER) is entirely safe by me. With that, I'm agreed, even in the public .h's :)