From dev-return-5604-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Jan 29 11:46:08 2002 Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 1149 invoked by uid 500); 29 Jan 2002 11:46:07 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 1138 invoked from network); 29 Jan 2002 11:46:06 -0000 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Tue, 29 Jan 2002 03:50:22 -0800 From: Greg Stein To: "William A. Rowe, Jr." Cc: Mladen Turk , dev@apr.apache.org Subject: Re: [PATCH] APR WCE Message-ID: <20020129035022.F12675@lyra.org> Mail-Followup-To: "William A. Rowe, Jr." , Mladen Turk , dev@apr.apache.org References: <002a01c1a845$a00c1240$2489bfd5@armada> <026e01c1a896$431169e0$94c0b0d0@v505> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <026e01c1a896$431169e0$94c0b0d0@v505>; from wrowe@covalent.net on Tue, Jan 29, 2002 at 01:25:33AM -0600 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N One short comment... On Tue, Jan 29, 2002 at 01:25:33AM -0600, William A. Rowe, Jr. wrote: > From: "Mladen Turk" > Sent: Monday, January 28, 2002 3:48 PM >... > +++ apr_general.h 28 Jan 2002 21:41:22 -0000 > @@ -133,13 +133,21 @@ > * have it > */ > #if (!APR_HAVE_STRCASECMP) && (APR_HAVE_STRICMP) > +#ifdef _MSC_VER > +#define strcasecmp(s1, s2) _stricmp(s1, s2) > > > You are looking to define a new APR_HAVE__STRICMP (or APR_HAVE_uSTRICMP, > whichever you find clearer.) It must be defined to 0 in apr.h.in. > > _MSC_VER is not namespace protected for APR, and apr_general.h is included _MSC_VER doesn't have to be namespace protected. He's only testing for it (to see if the compiler sets it). Why would it have to be protected? Cheers, -g -- Greg Stein, http://www.lyra.org/