apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: apr/network_io/win32 sockets.c
Date Fri, 04 Jan 2002 18:05:45 GMT
Jeff Trawick <trawick@attglobal.net> writes:

> bnicholes@apache.org writes:
> 
> > bnicholes    02/01/04 09:25:49
> > 
> >   Modified:    network_io/win32 sockets.c
> >   Log:
> >   Deferred the memory allocation for the new apr_socket_t until after the accept()
> >   call so that we don't chew up huge chunks of memory when using non-blocking
> >   sockets and also avoiding unnecessary memory allocations on error conditions.
> 
> I wonder:
> 
> . what sort of non-broken program would suffer with the code the way
>   it used to be?
> 
> . isn't there more total work done now on the normal path?

I meant to clarify that I don't intend this as a complaint.  (But I
would prefer to understand these issues before anybody made a similar
change to other, similar code :) )

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message