apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sander Striker" <stri...@apache.org>
Subject RE: [PATCH] Add --enable-pool-debug to configure
Date Mon, 14 Jan 2002 20:28:47 GMT
> From: Roy T. Fielding [mailto:fielding@ebuilt.com]
> Subject: Re: [PATCH] Add --enable-pool-debug to configure
> 
> 
>> +AC_ARG_ENABLE(pool-debug,
>> +  [  --enable-pool-debug[={yes|verbose}]],
>> +  [ if test -z "$enableval" -o "$enableval" = "yes"; then
>> +        APR_ADDTO(CPPFLAGS, -DAPR_POOL_DEBUG)
>> +    elif test "$enableval" = "verbose"; then
>> +        APR_ADDTO(CPPFLAGS, -DAPR_POOL_DEBUG_VERBOSE)
>> +    fi
>> +  ])
>> +
> 
> Why not use one APR_POOL_DEBUG symbol and give it values of 0 | 1 | 2 ???
>
> .....Roy

Errr, because I hadn't considered it?
No, seriously, we started with having only APR_POOL_DEBUG and
put #if defined(APR_POOL_DEBUG) lines in the pools code.  Only
recently have we added the verbose mode.

Regular users of the debug code* are used (I think) to passing
CPPFLAGS=-DAPR_POOL_DEBUG on their commandlines to enable
the pools debugging code.
Or did people actually open the file, uncomment the define,
close the file and recompile?  And personally I like the
fact of having debug enabled, when APR_POOL_DEBUG is simply
defined.

Ofcourse we could enable verbose mode (or any other modes)
by checking the actual value of APR_POOL_DEBUG.  I'd like
to hear how the 'debug users' feel about that before moving
to that approach.

As a sidenote, the --enable-pool-debug configure option is to
enable people (who don't use the debugging code a lot and
don't have the information in their head) to get debugging
enabled in a simple fashion.  A bit like --with-efence.

Sander

 
*) The old pools debug code.  Can't speak for the new, because
   it was just added a short while back.


Mime
View raw message