apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] APR WCE
Date Tue, 29 Jan 2002 20:35:53 GMT
On Tue, Jan 29, 2002 at 01:59:00PM -0600, William A. Rowe, Jr. wrote:
> From: "Greg Stein" <gstein@lyra.org>
> Sent: Tuesday, January 29, 2002 1:38 PM
> 
> 
> > Bill. Stop and think for a moment.
> > 
> > HAVE_FOO created problems because *we* defined that symbol.
> > 
> > _MSC_VER is not *defined* by us. We're just looking for it.
> > 
> > Thus, it is acceptable to *check* for it. Not to define, but to *check*.
> 
> Then to be robust and useful;
> 
> #if defined(WIN32) && defined(_MSC_VER) 
> 
> is entirely safe by me.  With that, I'm agreed, even in the public .h's :)


Ahem. "Overkill"

:-)

We do a lot of testing of platform-specific symbols without additional
annotations of the platform. But hey... it doesn't bother me if you want to
add that.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message