apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] APR WCE
Date Tue, 29 Jan 2002 19:38:42 GMT
On Tue, Jan 29, 2002 at 08:18:46AM -0600, William A. Rowe, Jr. wrote:
> From: "Greg Stein" <gstein@lyra.org>
> Sent: Tuesday, January 29, 2002 5:50 AM
>...
> > On Tue, Jan 29, 2002 at 01:25:33AM -0600, William A. Rowe, Jr. wrote:
>...
> > > _MSC_VER is not namespace protected for APR, and apr_general.h is included
> > 
> > _MSC_VER doesn't have to be namespace protected. He's only testing for it
> > (to see if the compiler sets it). Why would it have to be protected?
> 
> For the same reason as HAVE_FOO must be protected using buildconf, etc.

Bill. Stop and think for a moment.

HAVE_FOO created problems because *we* defined that symbol.

_MSC_VER is not *defined* by us. We're just looking for it.

Thus, it is acceptable to *check* for it. Not to define, but to *check*.

Clear?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message