apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] APR WCE
Date Tue, 29 Jan 2002 11:50:22 GMT
One short comment...

On Tue, Jan 29, 2002 at 01:25:33AM -0600, William A. Rowe, Jr. wrote:
> From: "Mladen Turk" <mturk@mappingsoft.com>
> Sent: Monday, January 28, 2002 3:48 PM
>...
> +++ apr_general.h 28 Jan 2002 21:41:22 -0000
> @@ -133,13 +133,21 @@
>   * have it
>   */
>  #if (!APR_HAVE_STRCASECMP) && (APR_HAVE_STRICMP) 
> +#ifdef _MSC_VER
> +#define strcasecmp(s1, s2) _stricmp(s1, s2)
> 
> 
> You are looking to define a new APR_HAVE__STRICMP (or APR_HAVE_uSTRICMP, 
> whichever you find clearer.)  It must be defined to 0 in apr.h.in.
> 
> _MSC_VER is not namespace protected for APR, and apr_general.h is included

_MSC_VER doesn't have to be namespace protected. He's only testing for it
(to see if the compiler sets it). Why would it have to be protected?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message