apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/memory/unix apr_pools.c
Date Thu, 24 Jan 2002 23:41:23 GMT
On Thu, Jan 24, 2002 at 01:41:17PM -0000, striker@apache.org wrote:
>...
>   + * | 7 | 6 | 5 | 4 | 3 | 2 | 1 | 0 |
>   + * ---------------------------------
>   + * |   |   |   |   |   |   |   | x |  General debug code enabled (good for --with-efence)
>   + *
>   + * |   |   |   |   |   |   | x |   |  Verbose output on stderr (report CREATE, CLEAR,
DESTROY)
>   + *
>   + * |   |   |   |   |   | x |   |   |  Lifetime checking. On each use of a pool, check
its lifetime.
>   + *                                    If the pool is out of scope, abort().  In combination
with
>   + *                                    the verbose flag above, it will output LIFE
in such an event
>   + *                                    prior to aborting.
>   + *
>   + * |   |   |   |   | x |   |   |   |  Pool owner checking.  On each use of a pool,
check if the
>   + *                                    current thread is the pools owner.  If not,
abort().  In
>   + *                                    combination with the verbose flag above, it
will output OWNER
>   + *                                    in such an event prior to aborting.  Use the
debug function
>   + *                                    apr_pool_set_owner() to switch a pools ownership.

All lines, *especially* comments, should be wrapped to 80 characters. Or
more line 78.

>...
>   +#if defined(APR_POOL_DEBUG)
>   +#    if (APR_POOL_DEBUG != 0) && (APR_POOL_DEBUG - 0 == 0)
>   +#        undef APR_POOL_DEBUG
>   +#        define APR_POOL_DEBUG 1
>   +#    endif
>   +#    if APR_POOL_DEBUG == 0
>   +#        undef APR_POOL_DEBUG
>   +#        define APR_POOL_DEBUG 1
>   +#    endif
>   +#else
>   +#    define APR_POOL_DEBUG 0
>   +#endif

I do not believe that spaces between the '#' and the directive is portable.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message