apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [PATCH] Add --enable-pool-debug to configure
Date Tue, 15 Jan 2002 07:22:47 GMT
On Mon, Jan 14, 2002 at 11:55:48AM -0800, Roy T. Fielding wrote:
> > +AC_ARG_ENABLE(pool-debug,
> > +  [  --enable-pool-debug[={yes|verbose}]],
> > +  [ if test -z "$enableval" -o "$enableval" = "yes"; then
> > +        APR_ADDTO(CPPFLAGS, -DAPR_POOL_DEBUG)
> > +    elif test "$enableval" = "verbose"; then
> > +        APR_ADDTO(CPPFLAGS, -DAPR_POOL_DEBUG_VERBOSE)
> > +    fi
> > +  ])
> > +
> 
> Why not use one APR_POOL_DEBUG symbol and give it values of 0 | 1 | 2 ???

+1.  This way we could expand or rearrange the verbosity later.

This seems as good a time as any to get it right - going to a 
numbered system seems best in the long run.  -- justin


Mime
View raw message